Use auto trick to catch missing header files for auto_revoke
#1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We forgot to apply the `auto` trick to catch missing header files at compile time. As a result, people who used `auto_revoke` didn't learn about missing header files until link time. Apply the same technique to auto-revoke event handler registeration. (Story time: A customer was running into linker errors due to a missing header file when they used `auto_revoke`. One thing they tried was switching to non-`auto_revoke` events, and then they got the compile-time error. But their conclusion wasn't "Oh, there's my problem" but rather "That made it worse, go back!")
Collaborator
|
FYI: #1117 |
Member
Author
|
Thanks for the heads-up. Will rework and return. |
Member
|
Introduced a regression with static event subscriptions. Repro: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to apply the
autotrick toauto_revokemethods to catch missing header files at compile time. As a result, people who usedauto_revokedidn't learn about missing header files until link time.Apply the same technique to auto-revoke event handler registration.
(Story time: A customer was running into linker errors due to a missing header file when they used
auto_revoke. One thing they tried was switching to non-auto_revokeevents, and then they got the compile-time error. But their conclusion wasn't "Oh, that's my problem" but rather "Oh no, that made it worse, go back!")