Skip to content

Conversation

@alvinhochun
Copy link
Contributor

This is not intended to be a replacement to the Azure build, but as a supplemental build. The added workflow performs builds and runs tests on x86 and x64, and also tries to build the nuget package.

@kennykerr
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kennykerr
Copy link
Collaborator

I forget the magical incantation to get GitHub to notice there's a new workflow in a PR... 🤔

@sylveon
Copy link
Contributor

sylveon commented Oct 14, 2022

Should we try at least building the tests on ARM64?

@kennykerr
Copy link
Collaborator

I forget the magical incantation to get GitHub to notice there's a new workflow in a PR... 🤔

It might not run until the workflow is in master, in which case we can just merge and then validate with a subsequent PR to test the workflow.

Should we try at least building the tests on ARM64?

Does GitHub support ARM64 builds now?

@sylveon
Copy link
Contributor

sylveon commented Oct 14, 2022

The CI image is shared with Microsoft hosted Azure Pipeline agents, and it has the ARM64 cross compiler installed. It's not an ARM64 machine though, so we can only try building the tests as basic sanity check, can't actually run them.

@kennykerr
Copy link
Collaborator

Got it, yes that's all the Azure build does as well.

@kennykerr
Copy link
Collaborator

@alvinhochun I enabled GitHub Actions on this repo after you created this PR, so I think you just need to push another commit to trigger the new workflow to run.

@riverar
Copy link

riverar commented Oct 14, 2022

@sylveon This isn't related to the PR here but just a heads up, Microsoft has private ARM64 runners in ADO.

@sylveon
Copy link
Contributor

sylveon commented Oct 14, 2022

Yeah I heard about it but I'm not in the preview

@kennykerr
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alvinhochun alvinhochun force-pushed the alvin/github-action-msvc branch from c94eeb3 to 8f181d2 Compare October 14, 2022 20:59
@kennykerr
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alvinhochun

This comment was marked as outdated.

@kennykerr
Copy link
Collaborator

I updated it to allow actions/checkout@v3 but will have to be restarted somehow...

@alvinhochun alvinhochun force-pushed the alvin/github-action-msvc branch from 8f181d2 to b8bf2be Compare October 14, 2022 21:07
@alvinhochun
Copy link
Contributor Author

Pushed again and now they're running.

@kennykerr
Copy link
Collaborator

Woohoo - now we need Clang and GNU workflows. 😜

@kennykerr
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennykerr kennykerr merged commit 3ff6631 into microsoft:master Oct 14, 2022
@kennykerr
Copy link
Collaborator

@alvinhochun the actions seem a little unreliable:

https://github.com/microsoft/cppwinrt/actions/runs/3267768111/jobs/5373367929

Rerunning often seems to fix them, but it would be nice to track down what's causing the frequent failures.

@kennykerr
Copy link
Collaborator

Never mind - this is another case of #1202 - be nice if the error was easier to see tho 😜

@alvinhochun
Copy link
Contributor Author

Yeah. This CI currently just runs the build_test_all.cmd script, which I guess is what the Azure build has been using. For the Clang tests (which I'm still experimenting with) I have a different test flow which should make the test output easier to see. I can later apply that to the MSVC tests too.

@kennykerr
Copy link
Collaborator

Sounds great!

@alvinhochun alvinhochun deleted the alvin/github-action-msvc branch December 11, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants