-
Notifications
You must be signed in to change notification settings - Fork 264
Add GitHub Action build and test workflow #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Action build and test workflow #1201
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I forget the magical incantation to get GitHub to notice there's a new workflow in a PR... 🤔 |
|
Should we try at least building the tests on ARM64? |
It might not run until the workflow is in master, in which case we can just merge and then validate with a subsequent PR to test the workflow.
Does GitHub support ARM64 builds now? |
|
The CI image is shared with Microsoft hosted Azure Pipeline agents, and it has the ARM64 cross compiler installed. It's not an ARM64 machine though, so we can only try building the tests as basic sanity check, can't actually run them. |
|
Got it, yes that's all the Azure build does as well. |
|
@alvinhochun I enabled GitHub Actions on this repo after you created this PR, so I think you just need to push another commit to trigger the new workflow to run. |
|
@sylveon This isn't related to the PR here but just a heads up, Microsoft has private ARM64 runners in ADO. |
|
Yeah I heard about it but I'm not in the preview |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
c94eeb3 to
8f181d2
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment was marked as outdated.
This comment was marked as outdated.
|
I updated it to allow |
8f181d2 to
b8bf2be
Compare
|
Pushed again and now they're running. |
|
Woohoo - now we need Clang and GNU workflows. 😜 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kennykerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@alvinhochun the actions seem a little unreliable: https://github.com/microsoft/cppwinrt/actions/runs/3267768111/jobs/5373367929 Rerunning often seems to fix them, but it would be nice to track down what's causing the frequent failures. |
|
Never mind - this is another case of #1202 - be nice if the error was easier to see tho 😜 |
|
Yeah. This CI currently just runs the |
|
Sounds great! |
This is not intended to be a replacement to the Azure build, but as a supplemental build. The added workflow performs builds and runs tests on x86 and x64, and also tries to build the nuget package.