Skip to content

check_bool<T> now returns T #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kennykerr merged 4 commits into from
Oct 24, 2022
Merged

check_bool<T> now returns T #1205

kennykerr merged 4 commits into from
Oct 24, 2022

Conversation

@jaigak
Copy link
Contributor

@jaigak jaigak commented Oct 15, 2022 •
edited
Loading

Closes #1204.

@kennykerr
Copy link
Collaborator

kennykerr commented Oct 15, 2022

Thanks, just needs a test. Perhaps here.

@jaigak
Copy link
Contributor Author

jaigak commented Oct 22, 2022

Thanks, just needs a test. Perhaps here.

Is it fine now?

@kennykerr
Copy link
Collaborator

kennykerr commented Oct 24, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 24, 2022

Azure Pipelines successfully started running 1 pipeline(s).

kennykerr
kennykerr reviewed Oct 24, 2022
View reviewed changes
@jaigak @kennykerr
Update test/old_tests/UnitTests/Errors.cpp
1f0226a 
Co-authored-by: Kenny Kerr <kenny@kennykerr.ca>
@kennykerr
Copy link
Collaborator

kennykerr commented Oct 24, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 24, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@kennykerr kennykerr merged commit 3deb508 into microsoft:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennykerr kennykerr kennykerr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

check_bool<T> should return T

2 participants

@jaigak @kennykerr