Skip to content

Fix invoke call on Clang (possibly a compiler bug) #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennykerr merged 3 commits into from
Nov 7, 2022
Merged

Fix invoke call on Clang (possibly a compiler bug) #1225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81ecef3
Re-enable some disconnected.cpp test cases for Clang
alvinhochun Nov 7, 2022
94424ac
Call winrt::impl::invoke with namespace specified
alvinhochun Nov 7, 2022
4f85e42
Two more disconnected.cpp test cases are now passing on Clang
alvinhochun Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions strings/base_coroutine_foundation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ namespace winrt::impl

if (handler)
{
invoke(handler, *this, status);
winrt::impl::invoke(handler, *this, status);
}
}

Expand Down Expand Up @@ -539,7 +539,7 @@ namespace winrt::impl

if (handler)
{
invoke(handler, *this, status);
winrt::impl::invoke(handler, *this, status);
}
}

Expand Down
20 changes: 0 additions & 20 deletions test/test/disconnected.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,7 @@ TEST_CASE("disconnected,handler,1")
source(nullptr, 123);
}

#if defined(__clang__)
// FIXME: Test is known to fail with unhandled exception when built with Clang.
TEST_CASE("disconnected,handler,2", "[!shouldfail]")
#else
TEST_CASE("disconnected,handler,2")
#endif
{
auto async = Action();

Expand All @@ -93,12 +88,7 @@ TEST_CASE("disconnected,handler,2")
});
}

#if defined(__clang__)
// FIXME: Test is known to abort when built with Clang. (Seems to be from unhandled exception thrown on a worker thread.)
TEST_CASE("disconnected,handler,3", "[.clang-crash]")
#else
TEST_CASE("disconnected,handler,3")
#endif
{
auto async = ActionProgress();
handle signal{ CreateEventW(nullptr, true, false, nullptr) };
Expand All @@ -117,12 +107,7 @@ TEST_CASE("disconnected,handler,3")
WaitForSingleObject(signal.get(), INFINITE);
}

#if defined(__clang__)
// FIXME: Test is known to fail with unhandled exception when built with Clang.
TEST_CASE("disconnected,handler,4", "[!shouldfail]")
#else
TEST_CASE("disconnected,handler,4")
#endif
{
auto async = Operation();

Expand All @@ -132,12 +117,7 @@ TEST_CASE("disconnected,handler,4")
});
}

#if defined(__clang__)
// FIXME: Test is known to abort when built with Clang. (Seems to be from unhandled exception thrown on a worker thread.)
TEST_CASE("disconnected,handler,5", "[.clang-crash]")
#else
TEST_CASE("disconnected,handler,5")
#endif
{
auto async = OperationProgress();
handle signal{ CreateEventW(nullptr, true, false, nullptr) };
Expand Down
20 changes: 0 additions & 20 deletions test/test_win7/disconnected.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,7 @@ TEST_CASE("disconnected,1")
source(nullptr, 123);
}

#if defined(__clang__)
// FIXME: Test is known to fail with unhandled exception when built with Clang.
TEST_CASE("disconnected,2", "[!shouldfail]")
#else
TEST_CASE("disconnected,2")
#endif
{
auto async = Action();

Expand All @@ -82,12 +77,7 @@ TEST_CASE("disconnected,2")
});
}

#if defined(__clang__)
// FIXME: Test is known to abort when built with Clang. (Seems to be from unhandled exception thrown on a worker thread.)
TEST_CASE("disconnected,3", "[.clang-crash]")
#else
TEST_CASE("disconnected,3")
#endif
{
auto async = ActionProgress();
handle signal{ CreateEventW(nullptr, true, false, nullptr) };
Expand All @@ -106,12 +96,7 @@ TEST_CASE("disconnected,3")
WaitForSingleObject(signal.get(), INFINITE);
}

#if defined(__clang__)
// FIXME: Test is known to fail with unhandled exception when built with Clang.
TEST_CASE("disconnected,4", "[!shouldfail]")
#else
TEST_CASE("disconnected,4")
#endif
{
auto async = Operation();

Expand All @@ -121,12 +106,7 @@ TEST_CASE("disconnected,4")
});
}

#if defined(__clang__)
// FIXME: Test is known to abort when built with Clang. (Seems to be from unhandled exception thrown on a worker thread.)
TEST_CASE("disconnected,5", "[.clang-crash]")
#else
TEST_CASE("disconnected,5")
#endif
{
auto async = OperationProgress();
handle signal{ CreateEventW(nullptr, true, false, nullptr) };
Expand Down