Skip to content

tests: Fix and enable cpp20/custom_error for incoming LLVM 16 #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennykerr merged 1 commit into from
Jan 30, 2023
Merged

tests: Fix and enable cpp20/custom_error for incoming LLVM 16 #1265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion test/test_cpp20/custom_error.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,14 @@ namespace
}
}

#if defined(__clang__)
#if defined(__clang__) && defined(_MSC_VER)
// FIXME: Blocked on __cpp_consteval, see:
// * https://github.com/microsoft/cppwinrt/pull/1203#issuecomment-1279764927
// * https://github.com/llvm/llvm-project/issues/57094
TEST_CASE("custom_error_logger", "[!shouldfail]")
#elif defined(_LIBCPP_VERSION) && _LIBCPP_VERSION < 160000
// <source_location> not available in libc++ before LLVM 16
TEST_CASE("custom_error_logger", "[!shouldfail]")
#else
TEST_CASE("custom_error_logger")
#endif
Expand All @@ -61,6 +64,8 @@ TEST_CASE("custom_error_logger")
REQUIRE(!functionNameSv.empty());
#if defined(__GNUC__) && !defined(__clang__)
REQUIRE(functionNameSv == "void {anonymous}::FailOnLine15()");
#elif defined(__GNUC__) && defined(__clang__)
REQUIRE(functionNameSv == "void (anonymous namespace)::FailOnLine15()");
#else
REQUIRE(functionNameSv == "FailOnLine15");
#endif
Expand Down