Skip to content

Enable prefast and warnings checker in SDL #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DefaultRyan merged 3 commits into from
Mar 1, 2025
Merged

Enable prefast and warnings checker in SDL #1477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f4b71b
Enable prefast and warning checkers
DefaultRyan Feb 28, 2025
f4011f9
globalSdl.isNativeCode is a simple bool, not an object with 'enabled'…
DefaultRyan Feb 28, 2025
0575d89
Re-enable SDL in cppwinrtvisualizer
DefaultRyan Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .pipelines/OneBranch.Official.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ extends:
enabled: false

globalSdl:
isNativeCode: true
asyncSdl:
enabled: true
tsa:
Expand All @@ -40,6 +41,8 @@ extends:
compiled:
enabled: true
tsaEnabled: true
prefast:
enabled: true

stages:
- stage: build
Expand Down
3 changes: 3 additions & 0 deletions .pipelines/OneBranch.PullRequest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,13 @@ extends:
product: 'build_tools'

globalSdl:
isNativeCode: true
tsa:
enabled: false
sbom:
enabled: true
prefast:
enabled: true

stages:
- stage: build
Expand Down
4 changes: 4 additions & 0 deletions .pipelines/jobs/OneBranchBuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ jobs:
${{ if eq(parameters.OfficialBuild, 'false') }}:
ob_sdl_codeSignValidation_excludes: '-|**\*.exe;-|**\*.dll'

ob_sdl_prefast_enabled: true
ob_sdl_prefast_runDuring: 'Build'
ob_sdl_checkCompliantCompilerWarnings: true

ob_symbolsPublishing_enabled: ${{ parameters.OfficialBuild }}
ob_symbolsPublishing_symbolsFolder: '$(ob_outputDirectory)'
ob_symbolsPublishing_searchPattern: '**\*.pdb'
Expand Down
4 changes: 4 additions & 0 deletions .pipelines/jobs/OneBranchNuGet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ jobs:
ob_outputDirectory: '$(Build.SourcesDirectory)\out'
PackageVersion: ${{ parameters.BuildVersion }}

ob_sdl_prefast_enabled: true
ob_sdl_prefast_runDuring: 'Build'
ob_sdl_checkCompliantCompilerWarnings: true

steps:
- task: UseDotNet@2
continueOnError: true
Expand Down
4 changes: 4 additions & 0 deletions .pipelines/jobs/OneBranchTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ jobs:
ob_artifactSuffix: $(TestExe).$(BuildPlatform)
ob_sdl_codeSignValidation_excludes: '-|**\*.exe;-|**\*.dll'

ob_sdl_prefast_enabled: true
ob_sdl_prefast_runDuring: 'Build'
ob_sdl_checkCompliantCompilerWarnings: true

BuildPath: '$(Build.SourcesDirectory)/_build/$(BuildPlatform)/${{ parameters.BuildConfiguration }}'

steps:
Expand Down
4 changes: 4 additions & 0 deletions .pipelines/jobs/OneBranchVsix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ jobs:
ob_symbolsPublishing_symbolsFolder: '$(ob_outputDirectory)'
ob_symbolsPublishing_searchPattern: '**\*.pdb'
ob_symbolsPublishing_indexSources: true

ob_sdl_prefast_enabled: true
ob_sdl_prefast_runDuring: 'Build'
ob_sdl_checkCompliantCompilerWarnings: true

steps:
- task: UseDotNet@2
Expand Down
6 changes: 0 additions & 6 deletions natvis/cppwinrtvisualizer.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@
<PrecompiledHeader>Use</PrecompiledHeader>
<WarningLevel>Level4</WarningLevel>
<Optimization>Disabled</Optimization>
<SDLCheck>false</SDLCheck>
<PreprocessorDefinitions>VSDEBUGENG_USE_CPP11_SCOPED_ENUMS;WIN32;_DEBUG;VISUALIZER_EXPORTS;_WINDOWS;_USRDLL;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<AdditionalIncludeDirectories>$(IntDir);..\cppwinrt;..\strings;$(DIASDKInc);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<LanguageStandard>stdcpp20</LanguageStandard>
Expand All @@ -129,7 +128,6 @@
<PrecompiledHeader>Use</PrecompiledHeader>
<WarningLevel>Level4</WarningLevel>
<Optimization>Disabled</Optimization>
<SDLCheck>false</SDLCheck>
<PreprocessorDefinitions>VSDEBUGENG_USE_CPP11_SCOPED_ENUMS;_DEBUG;VISUALIZER_EXPORTS;_WINDOWS;_USRDLL;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<AdditionalIncludeDirectories>$(IntDir);..\cppwinrt;..\strings;$(DIASDKInc);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<LanguageStandard>stdcpp20</LanguageStandard>
Expand All @@ -153,7 +151,6 @@
<PrecompiledHeader>Use</PrecompiledHeader>
<WarningLevel>Level4</WarningLevel>
<Optimization>Disabled</Optimization>
<SDLCheck>false</SDLCheck>
<PreprocessorDefinitions>VSDEBUGENG_USE_CPP11_SCOPED_ENUMS;_DEBUG;VISUALIZER_EXPORTS;_WINDOWS;_USRDLL;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<AdditionalIncludeDirectories>$(IntDir);..\cppwinrt;..\strings;$(DIASDKInc);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<LanguageStandard>stdcpp20</LanguageStandard>
Expand All @@ -179,7 +176,6 @@
<Optimization>MaxSpeed</Optimization>
<FunctionLevelLinking>true</FunctionLevelLinking>
<IntrinsicFunctions>true</IntrinsicFunctions>
<SDLCheck>false</SDLCheck>
<PreprocessorDefinitions>VSDEBUGENG_USE_CPP11_SCOPED_ENUMS;WIN32;NDEBUG;VISUALIZER_EXPORTS;_WINDOWS;_USRDLL;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<AdditionalIncludeDirectories>$(IntDir);..\cppwinrt;..\strings;$(DIASDKInc);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<LanguageStandard>stdcpp20</LanguageStandard>
Expand Down Expand Up @@ -209,7 +205,6 @@
<Optimization>MaxSpeed</Optimization>
<FunctionLevelLinking>true</FunctionLevelLinking>
<IntrinsicFunctions>true</IntrinsicFunctions>
<SDLCheck>false</SDLCheck>
<PreprocessorDefinitions>VSDEBUGENG_USE_CPP11_SCOPED_ENUMS;NDEBUG;VISUALIZER_EXPORTS;_WINDOWS;_USRDLL;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<AdditionalIncludeDirectories>$(IntDir);..\cppwinrt;..\strings;$(DIASDKInc);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<LanguageStandard>stdcpp20</LanguageStandard>
Expand Down Expand Up @@ -239,7 +234,6 @@
<Optimization>MaxSpeed</Optimization>
<FunctionLevelLinking>true</FunctionLevelLinking>
<IntrinsicFunctions>true</IntrinsicFunctions>
<SDLCheck>false</SDLCheck>
<PreprocessorDefinitions>VSDEBUGENG_USE_CPP11_SCOPED_ENUMS;NDEBUG;VISUALIZER_EXPORTS;_WINDOWS;_USRDLL;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<AdditionalIncludeDirectories>$(IntDir);..\cppwinrt;..\strings;$(DIASDKInc);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<LanguageStandard>stdcpp20</LanguageStandard>
Expand Down