Skip to content

Restore basic Clang support #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennykerr merged 1 commit into from
Oct 15, 2019
Merged

Restore basic Clang support #383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions strings/base_array.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,27 +31,17 @@ WINRT_EXPORT namespace winrt
array_view(value, N)
{}

template <typename = std::enable_if_t<std::is_same_v<T, bool>>>
array_view(std::vector<bool>& value) noexcept
{
static_assert(false, "Cannot use std::vector<bool> as an array_view. Consider std::array or std::unique_ptr<bool[]>.");
}

template <typename = std::enable_if_t<std::is_same_v<T, bool>>>
array_view(std::vector<bool> const& value) noexcept
{
static_assert(false, "Cannot use std::vector<bool> as an array_view. Consider std::array or std::unique_ptr<bool[]>.");
}

template <typename C>
array_view(std::vector<C>& value) noexcept :
array_view(value.data(), static_cast<size_type>(value.size()))
{}
array_view(data(value), static_cast<size_type>(value.size()))
{
}

template <typename C>
array_view(std::vector<C> const& value) noexcept :
array_view(value.data(), static_cast<size_type>(value.size()))
{}
array_view(data(value), static_cast<size_type>(value.size()))
{
}

template <typename C, size_t N>
array_view(std::array<C, N>& value) noexcept :
Expand Down Expand Up @@ -208,6 +198,22 @@ WINRT_EXPORT namespace winrt

pointer m_data{ nullptr };
size_type m_size{ 0 };

private:

template <typename C>
auto data(std::vector<C> const& value) noexcept
{
static_assert(!std::is_same_v<C, bool>, "Cannot use std::vector<bool> as an array_view. Consider std::array or std::unique_ptr<bool[]>.");
return value.data();
}

template <typename C>
auto data(std::vector<C>& value) noexcept
{
static_assert(!std::is_same_v<C, bool>, "Cannot use std::vector<bool> as an array_view. Consider std::array or std::unique_ptr<bool[]>.");
return value.data();
}
};

template <typename T>
Expand Down