Override GetResolvedWinMD to make sure all native build targets are aware of the C++/WinRT produced WinMD. #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nMD. VS uses this to resolve project output.
kennykerr
reviewed
Nov 26, 2019
kennykerr
reviewed
Nov 26, 2019
Scottj1s
reviewed
Nov 26, 2019
Scottj1s
reviewed
Nov 26, 2019
Scottj1s
reviewed
Nov 26, 2019
Member
|
I'm a bit nervous about overriding all these internal CX targets. That has the potential to make our nuget brittle (or at least specific to VS versions). What's wrong with the alternative of just setting GenerateWindowsMetadata back to true for the RC project template? You describe that as a "workaround" - how so? |
Contributor
Author
|
These are standard OutputGroup targets, meant to be overriden. |
Contributor
Author
|
@Scottj1s the other option is for us to override the GetResolvedWinMD target, to make it aware of the C++/WInRT WinMD. Thoughts? |
jlaanstra
changed the title
kennykerr
requested changes
Nov 26, 2019
Collaborator
kennykerr
left a comment
kennykerr
left a comment
There was a problem hiding this comment.
Have we confirmed that:
- this allows both C#->C++ project references and
- activation works in that scenario automatically and
- a basic Razzle project builds successfully?
Contributor
Author
|
@kennykerr Added todo's, so you can see what I have verified. |
Scottj1s
reviewed
Nov 26, 2019
| Condition="'$(CppWinRTGenerateWindowsMetadata)' == 'true'" | ||
| <!-- This target overrides the GetResolvedWinMD target used to resolve the WinMD for native projects | ||
| so it is aware of the C++/WinRT generated WinMD. | ||
| Since not every project that consumesd C++/WinRT uses it to generate a WinMD, |
Member
|
ok, let's give it a spin with vsix/razzle |
Scottj1s
approved these changes
Nov 27, 2019
…References, so it can't depend on it.
kennykerr
approved these changes
Nov 27, 2019
kennykerr
reviewed
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the project templates no longer set the flags that enable the MSBuild logic to tell MSBuild about the CX generated WinMD, we have to override the GetResolvedWinMD target to ensure that VS and MSBuild pick up the correct WinMD project output. Unfortunately the target is not very extensible, so we have to override it.
VS uses this to resolve project output and without this change the PrimaryWinMDFullPath itemgroup is empty resulting in VS being unable to add project references to C++/WinRT projects.
TODO:
Fixes #425