Skip to content

Conversation

@kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Nov 27, 2019

A collection of changes to address various issues with IntelliSense usability.

  • Use = instead of { } for variable templates to workaround IntelliSense bug
  • Use WINRT_IMPL_AUTO to avoid poor IntelliSense performance due to return type deduction
  • Address type conversion warnings from IntelliSense compiler

Also a tweak to avoid brittle ABI headers not defining GUID specializations.

Fixes #384

@kennykerr kennykerr requested a review from Scottj1s November 27, 2019 20:24
Copy link
Member

@ChrisGuzak ChrisGuzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this.

@kennykerr kennykerr merged commit fd4b105 into master Nov 27, 2019
@kennykerr kennykerr deleted the kennykerr-auto branch November 27, 2019 20:26

#define WINRT_IMPL_SHIM(...) (*(abi_t<__VA_ARGS__>**)&static_cast<__VA_ARGS__ const&>(static_cast<D const&>(*this)))

#ifdef __INTELLISENSE__

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going through this macro route, it would be a "syntax changing macro" that probably should be included in the hint file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IntelliSense is getting slaughtered

4 participants