Provide the correct path to the implementation dll. #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennykerr
approved these changes
Dec 18, 2019
Collaborator
|
Hi @jlaanstra could you resolve this branch conflict. Then we can merge into master. |
jlaanstra
force-pushed
the
user/jlaans/implementation
branch
from
b7e25ed to
4ce87d7
Compare
Contributor
Author
|
@kennykerr done. |
Contributor
|
My project does not build without this PR, is there any estimate as to when I should see a release on NuGet with this fix? |
Collaborator
|
@sylveon I just published 2.0.200107.1 with a rollup of fixes. |
Contributor
|
This version works, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the path to the implementation dll for a WinMD to use
$(TargetPath)instead of$(RootNamespace)which is incorrect when they differ. Also added a test project to make sure this keeps working going forward.Fixes #449