Clang conformance #483
Merged
Clang conformance #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefaultRyan
approved these changes
Jan 17, 2020
| } | ||
|
|
||
| [[noreturn]] inline void terminate() noexcept | ||
| inline void terminate() noexcept |
Member
There was a problem hiding this comment.
Really? This one is surprising to me.
Collaborator
Author
There was a problem hiding this comment.
Yes, Clang can't tell that the function won't return and thus rejects the [[noreturn]]. Unfortunately, there seems to be no way to mark a lambda as [[noreturn]] and even if there were, I'm not sure Clang would "see through" the load_runtime_function function to observe this since the RoFailFastWithErrorContext function isn't [[noreturn]] due to its dynamic nature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tweaks for Clang conformance. As a bonus, the Clang compiler picked up a source bug.