Fix bug where CppWinRT would drop static library references. #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
jlaanstra
force-pushed
the
user/jlaans/504
branch
from
47fa94e to
f6c19de
Compare
Contributor
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
… test for the scenario.
jlaanstra
force-pushed
the
user/jlaans/504
branch
from
f6c19de to
fb3be54
Compare
Contributor
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
kennykerr
approved these changes
Jan 30, 2020
ChrisGuzak
reviewed
Jan 30, 2020
Member
ChrisGuzak
left a comment
ChrisGuzak
left a comment
There was a problem hiding this comment.
thank you for taking on this work
ChrisGuzak
reviewed
Jan 30, 2020
| and then remove them. --> | ||
| <Target Name="CppWinRTRemoveStaticLibraries" | ||
| DependsOnTargets="GetCppWinRTProjectWinMDReferences" | ||
| <!-- Static library reference WinMDs are merged into the project WinMD that |
ChrisGuzak
reviewed
Jan 30, 2020
| references it and might have the same name because they often share namespace. | ||
| Therefore they shouldn't be copied to the output folder | ||
| because they might override files in the output folder with the | ||
| same name, causing missing types. --> |
Member
There was a problem hiding this comment.
consider "missing types when linking"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A WinMD file produced by a static library gets merged into the WinMD of the Dll project consuming the library. Because they often share a root namespace, the files might have the same name and they can overwrite each other in the output folder.
The way this was fixed is to simply remove the static lib from the list of project references. However this causes issues for the case where a CX dll project references a C++/WinRT static library as it doesn't see the reference. A better fix is to mark the reference as private so it won't be copied to the output directory of the Dll project.
TODO:
Fixes #504