Skip to content

Set better defaults for references and project references to keep MdMerge happy. #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlaanstra merged 1 commit into from
Jun 11, 2020
Merged

Set better defaults for references and project references to keep MdMerge happy. #612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions nuget/Microsoft.Windows.CppWinRT.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,20 @@ Copyright (C) Microsoft Corporation. All rights reserved.
<ProxyFileName Condition="'%(Midl.ProxyFileName)'==''">nul</ProxyFileName>
<TypeLibraryName Condition="'%(Midl.TypeLibraryName)'==''"></TypeLibraryName>
</Midl>
<ProjectReference Condition="'$(XamlLanguage)' != 'C++'">
Copy link
Member

@Scottj1s Scottj1s May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are defaults. if necessary, users could explicitly override in the IDE?

Copy link
Contributor Author

@jlaanstra jlaanstra May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Overrides are possible per reference, for all references or conditionally.

<!-- By default, for a C++/WinRT project,
don't copy project reference output to the output directory
of the current project unless this is an exe. -->
<Private>false</Private>
<Private Condition="'$(ConfigurationType)' == 'Application' or '$(OutputType)'=='winexe' or '$(OutputType)'=='exe' or '$(OutputType)'=='appcontainerexe'">true</Private>
</ProjectReference>
<Reference Condition="'$(XamlLanguage)' != 'C++'">
<!-- By default, for a C++/WinRT project,
don't copy reference output to the output directory
of the current project unless this is an exe. -->
<Private>false</Private>
<Private Condition="'$(ConfigurationType)' == 'Application' or '$(OutputType)'=='winexe' or '$(OutputType)'=='exe' or '$(OutputType)'=='appcontainerexe'">true</Private>
</Reference>
</ItemDefinitionGroup>

<ItemGroup>
Expand Down