[ARM64] Fix CFG helper calling convention and simplify flow of call target address. #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmsjt
changed the title
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
Thanks for the contribution! 🎉 |
kennykerr
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike other architectures, on ARM64 __guard_check_icall_fptr follows a custom calling convention. X15 takes the address of the target method and that value is preserved across the call.
As a result, there is no need to enlist the help of the x19 non-volatile register. In turn, no need to spill/fill it.