Add SDKReference-sourced WinMDs when building #679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
Thanks for the contribution! 🎉 |
ChrisGuzak
approved these changes
Jul 3, 2020
kennykerr
approved these changes
Jul 3, 2020
jlaanstra
reviewed
Jul 7, 2020
| <!--Get direct WinMD references (including Nuget packages) for projections, IDL processing, and AppX packaging--> | ||
| <Target Name="GetCppWinRTDirectWinMDReferences" | ||
| DependsOnTargets="ResolveAssemblyReferences;$(GetCppWinRTDirectWinMDReferencesDependsOn)" | ||
| DependsOnTargets="ExpandSDKReferences;ResolveAssemblyReferences;$(GetCppWinRTDirectWinMDReferencesDependsOn)" |
Contributor
There was a problem hiding this comment.
This is unnecessary as ResolveAssemblyReferences already depends on it, but also doesn't hurt to have it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #677 by:
ExpandSDKReference