Skip to content

Conversation

@dunhor
Copy link
Member

@dunhor dunhor commented Jul 29, 2020

std::vector<bool> returns proxy objects for iteration/indexing, so switching to forwarding references where necessary. Still using std:move (over std::forward) since the intent is taking ownership.

@dunhor dunhor requested a review from kennykerr July 29, 2020 18:00
Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennykerr kennykerr merged commit 820fed5 into master Jul 29, 2020
@kennykerr kennykerr deleted the dunhor/vector-of-bool branch July 29, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants