Skip to content

Conversation

@jlaanstra
Copy link
Contributor

@jlaanstra jlaanstra commented Jul 29, 2020

Set Private explicitly to false for certain projects instead of setting it to false for everything and then setting it true for certain projects and allow projects to opt-out.

TODO:

  • Add docs for the new property.

@jlaanstra
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@jlaanstra jlaanstra requested a review from kennykerr July 29, 2020 19:11
@kennykerr
Copy link
Collaborator

@jlaanstra "/azp run" is no longer required.

@kennykerr
Copy link
Collaborator

Maybe add documentation for what this is for here: https://github.com/microsoft/cppwinrt/tree/master/nuget

@kennykerr
Copy link
Collaborator

Is this PR still active?

@jlaanstra
Copy link
Contributor Author

@kennykerr yes it is. I still need to add docs for the property.

…ng it to false for everything and then setting it true for certain projects.
@jlaanstra
Copy link
Contributor Author

@kennykerr this is ready to merged.

@kennykerr kennykerr merged commit e504a0e into master Sep 16, 2020
@kennykerr kennykerr deleted the user/jlaans/opt-out branch September 16, 2020 02:55
@kennykerr
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants