Delete the rsp files on error and be smarter about detecting deleted files. #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaanstra
force-pushed
the
user/jlaans/incremental-updates
branch
from
c9ef92a to
ccbc4bb
Compare
jlaanstra
force-pushed
the
user/jlaans/incremental-updates
branch
from
1ddf312 to
e720ef1
Compare
kennykerr
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the rsp files on error and be smarter about detecting deleted input files, by using a technique similar to what the C# compiler is using here: https://github.com/dotnet/msbuild/blob/0e7b70f663ab86af7ab41d5d7b409f72f7143899/src/Tasks/Microsoft.Common.CurrentVersion.targets#L3397-L3427
Fixes #706
TODO: