VS 2017 compatibility for enable_await_cancellation #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VS 2017 requires accessible copy constructor even though it is never used. Turns out we're okay with `enable_await_cancellation` being copied, as long as it's not copied while awaiting (which we don't do). So go ahead and let it be copyable. VS 2017 also reports an unused variable error when the use of the `promise` is removed via `if constexpr`. Mark it as `[[maybe_unused]]` to help the compiler.
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS 2017 requires an accessible copy constructor even though it is never used. Turns out we're okay with
enable_await_cancellationbeing copied, as long as it's not copied while awaiting (which we don't do). So go ahead and let it be copyable.VS 2017 also reports an unused variable error when the use of the
promiseis removed viaif constexpr. Mark it as[[maybe_unused]]to help the compiler.