Skip to content

Conversation

@jlaanstra
Copy link
Contributor

@jlaanstra jlaanstra commented Oct 19, 2020

Fixes #773

TODO

  • Validate razzle build.

@jlaanstra jlaanstra requested a review from Scottj1s October 19, 2020 22:12
@jlaanstra
Copy link
Contributor Author

Validated the razzle build after reverting #742

@jlaanstra jlaanstra merged commit 5ffa6d9 into master Oct 20, 2020
@jlaanstra jlaanstra deleted the user/jlaans/773 branch October 20, 2020 17:40
@DHowett
Copy link
Member

DHowett commented Oct 27, 2020

terminal is seeing some build failures due to platform types missing when transitively used in projects that depend on winmds produced by other components with the latest version; could this be related?

MDMERGE : error MDM2002: The type "Windows.Foundation.IReference`1" defined in file Microsoft.Terminal.TerminalControl.winmd was referenced by type Microsoft.Terminal.TerminalControl.ICoreSettings but could not be found. [src\cascadia\UnitTests_TerminalCore\UnitTests.vcxproj]

cppwinrt : error Type 'Windows.Foundation.EventRegistrationToken' could not be found
 method: TerminalOutput
 type: Microsoft.Terminal.TerminalConnection.ITerminalConnection
 database: C:\Users\Dustin\src\terminal\x64\Release\TerminalConnection\Microsoft.Terminal.TerminalConnection.w
inmd

@DHowett
Copy link
Member

DHowett commented Oct 27, 2020

(Rolling back one version to 2.0.201017.1 fixes our build. 2.0.201026 is broken; this seems to be the only changeset that addresses platform winmds in the new version.)

@jlaanstra
Copy link
Contributor Author

jlaanstra commented Oct 27, 2020

@DHowett can you share a binlog from your build? Happy to take a look. You can probably apply the same fix from #781 to get unblocked as your unit test project is probably not targeting UAP and so the default targets don't add the WinMDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build targets pass a separate list of reference to MIDL then they generate a platform projection for.

4 participants