Visualizer should try to find winmd for interface and property types,… #864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and should fail more gracefully when not found.
Currently, if the visualizer only tries to load up new winmds for missing runtimeclasses in the case of top-level types and their bases. It then assumes the type graph should be fully resolvable, even for interfaces and properties, and throws an exception if they aren't found at this point.
There are two problems with this approach:
runtimeclass MyApp.Foo { Component.Widget MyProperty; }- we may have loaded MyApp.winmd, but that doesn't mean Component.winmd has been loaded, so we should extend the metadata loading courtesy to interface and property lookups.