Reduce size of compiled base.h due to get_runtime_activation_factory #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefaultRyan
approved these changes
Mar 10, 2021
kennykerr
approved these changes
Mar 10, 2021
Collaborator
|
In future, please use a local branch as I cannot run the CI build from remote branches. |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @Austin-Lamb
A sample project that uses cppwinrt heavily, weighed 919040 bytes (897kB) - (Release/x64, all optimizations turned on)
After refactoring get_runtime_activation_factory so that the bulk of the code can fold, the binary weighed 646656 bytes (631kB).
This is a reduction in disk footprint of 30% for the entire binary.