Conversation
The logic for deciding how to capture things is now moved into capture_to, so that we don't have to repeat it four times: (Free function vs member function) x (capture vs try_capture).
This saves the hassle of having to wrap the raw pointer inside a temporary com_ptr or a lambda.
If O can have "pointer to members", then it's not a function pointer.
This forces the class to use generalized function pointers, even if it would have used optimized function pointers had it been complete. Switch to std::is_class_v and std::is_union_v to detect that a type can have member functions.
kennykerr
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves the hassle of having to wrap the raw pointer inside a temporary com_ptr or a lambda.
This PR is in two commits. The first is a refactor so that all the capturing functions funnel through to a single
capture_to.The second is the one that adds
capture_tosupport for capturing from a raw pointer.