Skip to content

Conversation

@DefaultRyan
Copy link
Member

This updates the VSIX to work with Dev17 (VS 2022) Preview.

One thing I learned is that the VCTargets install path was deprecated starting in VS2019, so I had to update it to an explicit path under MSBuild.

See:

The second link suggests that the new path won't work in VS2017, and I thought we didn't still support VS2017, so I've moved up the minimum VS version from 2017 to 2019.

@DefaultRyan DefaultRyan requested a review from kennykerr June 28, 2021 19:48
@DefaultRyan
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@sylveon
Copy link
Contributor

sylveon commented Jun 28, 2021

Could you consider taking a look to #918 to see if we can roll it in at the same time?

Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @jlaanstra is happy with this that's good enough for me.

@DefaultRyan DefaultRyan merged commit 634d627 into master Jul 1, 2021
@DefaultRyan DefaultRyan deleted the defaultryan/dev17_vsix branch July 1, 2021 17:51
@DefaultRyan DefaultRyan linked an issue Jul 6, 2021 that may be closed by this pull request
@tim-weis
Copy link

Dropping VS2017 support is somewhat unfortunate. VS2017 has one distinct feature that all successors are missing: The ability to deploy an application from layout to a USB-attached Windows 10 Mobile device, allowing immediate on-device debugging.

Unless I'm the Last Man Standing that still supports Windows 10 Mobile for several applications, could you re-evaluate the cost/risk/effort of continuing VS2017 support, and ideally re-enable VS2017 that support?

@kennykerr
Copy link
Collaborator

@tim-weis can you use an older version the VSIX for your VS 2017 install? Sadly as it is, we hardly have the resources to keep the VSIX running with the latest version.

@s-wtnb
Copy link

s-wtnb commented Aug 12, 2021

@kennykerr Where can I find older versions of VSIX for VS 2017?
Do I need to build from C++/WinRT source code(contains VSIX) prior to the 2.0.210505.3 version that has this fix?

@kennykerr
Copy link
Collaborator

I don't actually know. I assumed the marketplace lets you download older versions, but there doesn't appear to be anything obvious there for finding older versions. Perhaps you can fiddle with the download link.

https://aka.ms/cppwinrt/vsix

@s-wtnb
Copy link

s-wtnb commented Aug 13, 2021

thx!
I was able to get the old VSIX by changing the version part of the URI in the download link.

ex)
2.0.210505.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VS 2022 VSIX support

9 participants