feat: section header when appending existing .gitignore#132
Merged
Skn0tt merged 2 commits intomicrosoft:mainfrom Oct 29, 2024
hamirmahal:style/separate-addition-of-playwright-entries-in-gitignore
Merged
feat: section header when appending existing .gitignore#132Skn0tt merged 2 commits intomicrosoft:mainfrom hamirmahal:style/separate-addition-of-playwright-entries-in-gitignore
.gitignore#132Skn0tt merged 2 commits intomicrosoft:mainfrom
hamirmahal:style/separate-addition-of-playwright-entries-in-gitignore
Conversation
hamirmahal
commented
Oct 25, 2024
|
|
||
| test('should install with "npm ci" in GHA when using npm with package-lock enabled', async ({ dir, run, packageManager }) => { | ||
| test.skip(packageManager !== 'npm'); | ||
Contributor
Author
There was a problem hiding this comment.
I think we should add automatic formatting to this repository to reduce noise from changes like this one.
Skn0tt
changed the title
playwright entries.gitignore
Skn0tt
approved these changes
Oct 29, 2024
Member
Skn0tt
left a comment
Skn0tt
left a comment
There was a problem hiding this comment.
The change looks good. Thank you!
hamirmahal
deleted the
style/separate-addition-of-playwright-entries-in-gitignore
branch
Contributor
Author
|
You're welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes microsoft/playwright#33307.