Skip to content

feat: support install playwright in pnpm workspace root#91

Closed
AkaraChen wants to merge 1 commit intomicrosoft:mainfrom
AkaraChen:feat-support-pnpm-workspace
Closed

feat: support install playwright in pnpm workspace root#91
AkaraChen wants to merge 1 commit intomicrosoft:mainfrom
AkaraChen:feat-support-pnpm-workspace

Conversation

@AkaraChen
Copy link
Copy Markdown

pnpm create playwright getting error in pnpm monorepo.

Relative issues: microsoft/playwright#27203

image

Fixed by look up ${process.cwd()}/pnpm-workspace.yaml

@AkaraChen
Copy link
Copy Markdown
Author

@AkaraChen please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@aroman
Copy link
Copy Markdown

aroman commented Aug 9, 2023

ran into this today... was a painful experience

@AkaraChen
Copy link
Copy Markdown
Author

ran into this today... was a painful experience

For workaround, you can delete pnpm-workspace.yaml,init playwright,finally git discard change

@AkaraChen
Copy link
Copy Markdown
Author

@AkaraChen the command you issued was incorrect. Please try again.

Examples are:

@microsoft-github-policy-service agree

and

@microsoft-github-policy-service agree company="your company"

@microsoft-github-policy-service agree

@karlhorky
Copy link
Copy Markdown
Contributor

karlhorky commented Jun 20, 2024

@AkaraChen was this already fixed + merged in the following PR?

Seems like it was released in create-playwright@1.17.131

@AkaraChen AkaraChen closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants