[release/0.22] Fix: Add --container-runtime flag to run-controllers command#83
Merged
danegsta merged 2 commits intorelease/0.22from Feb 14, 2026
Merged
Conversation
This fixes the issue where start-apiserver was forwarding the --container-runtime flag to run-controllers, which didn't accept it, causing the controllers subprocess to crash with exit code 1. Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Backports the fix ensuring the dcp run-controllers subcommand accepts the --container-runtime flag that is forwarded from start-apiserver, preventing the controllers subprocess from crashing on startup.
Changes:
- Register
--container-runtimeon therun-controllerscobra command viacontainer_flags.EnsureRuntimeFlag(...).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
karolz-ms
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #82 to release/0.22
/cc @danegsta @copilot
Customer Impact
Enables --container-runtime flag on run-controllers sub-command.
Testing
Automated suite
Risk
Low
Regression?
Yes, due to the move to a single binary, that flag didn’t make the move as it was defined on the dcpctrl root command.