Skip to content

Require new packages for TS interdependencies #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfullerton44 merged 7 commits into from
Jan 9, 2024
+8 −3
Merged

Require new packages for TS interdependencies #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
11deec2
require new packages
jfullerton44 Dec 4, 2023
61987f4
Add docs
jfullerton44 Dec 4, 2023
56287ef
more docs
jfullerton44 Dec 4, 2023
5095854
PR suggestions
jfullerton44 Dec 4, 2023
bb6ef3a
update package versions
jfullerton44 Dec 19, 2023
1cc56eb
Merge branch 'main' into dev/jfullerton/tsPackageVersion
jfullerton44 Dec 19, 2023
00dbc26
Merge branch 'main' of https://github.com/microsoft/dev-tunnels into …
jfullerton44 Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,6 @@ Fixes #
-

### Other Tasks:

- [ ] If you updated the Go SDK did you update the PackageVersion in tunnels.go
- [ ] If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version(Found using `npm view @microsoft/dev-tunnels-contracts`). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See [example PR](https://github.com/microsoft/dev-tunnels/pull/358)
3 changes: 3 additions & 0 deletions ts/README-dev.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,6 @@ npm run test
```
To run/debug an individual test case or subset of test cases matching a
substring, use a command similar to the following:

## Making Changes
If you update this SDK, please update the package.json file in conenctions and management to require a dependeny that is > the current published version(You can find this with the `npm view @microsoft/dev-tunnels-contracts` command). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See [example PR](https://github.com/microsoft/dev-tunnels/pull/358)
4 changes: 2 additions & 2 deletions ts/src/connections/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
"buffer": "^5.2.1",
"debug": "^4.1.1",
"vscode-jsonrpc": "^4.0.0",
"@microsoft/dev-tunnels-contracts": "^1.0.0",
"@microsoft/dev-tunnels-management": "^1.0.0",
"@microsoft/dev-tunnels-contracts": ">1.1.1",
"@microsoft/dev-tunnels-management": ">1.1.1",
"@microsoft/dev-tunnels-ssh": "^3.11.36",
"@microsoft/dev-tunnels-ssh-tcp": "^3.11.36",
"uuid": "^3.3.3",
Expand Down
2 changes: 1 addition & 1 deletion ts/src/management/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"buffer": "^5.2.1",
"debug": "^4.1.1",
"vscode-jsonrpc": "^4.0.0",
"@microsoft/dev-tunnels-contracts": "^1.0.0",
"@microsoft/dev-tunnels-contracts": ">1.1.1",
"axios": "^1.6.2"
}
}