Skip to content

Add api-version to check-name requests#380

Merged
jfullerton44 merged 1 commit intomainfrom
dev/jfullerton/checkNameVersion
Jan 10, 2024
Merged

Add api-version to check-name requests#380
jfullerton44 merged 1 commit intomainfrom
dev/jfullerton/checkNameVersion

Conversation

@jfullerton44
Copy link
Copy Markdown
Collaborator

Fixes an issue where the api-version param was not included in check-name requests

Other Tasks:

  • If you updated the Go SDK did you update the PackageVersion in tunnels.go
  • If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version(Found using npm view @microsoft/dev-tunnels-contracts). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See example PR

@jfullerton44 jfullerton44 enabled auto-merge (squash) January 10, 2024 21:38
@jfullerton44 jfullerton44 merged commit 869adce into main Jan 10, 2024
@jfullerton44 jfullerton44 deleted the dev/jfullerton/checkNameVersion branch January 10, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants