Add cancellation token and default timeout (20s) to service requests#382
Merged
Add cancellation token and default timeout (20s) to service requests#382
Conversation
- pass cancellationToken in to refreshPorts -
…t to require a dependency that is > the current published version
osortega
reviewed
Jan 22, 2024
osortega
left a comment
There was a problem hiding this comment.
Would it be better to handle request retries completely within the SDK if there is already a way to track a request done through the SSH session?
This way it would be a transparent implementation on the user side instead of implementing the same thing for every API.
jasongin
requested changes
Jan 22, 2024
…H session to close.
jasongin
reviewed
Jan 23, 2024
jasongin
reviewed
Jan 23, 2024
jasongin
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed:
Other Tasks:
npm view @microsoft/dev-tunnels-contracts). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See example PR