Skip to content

Improve timeout messaging#384

Merged
jramsay merged 2 commits intomainfrom
dev/jasonra/timeout-improvements
Jan 24, 2024
Merged

Improve timeout messaging#384
jramsay merged 2 commits intomainfrom
dev/jasonra/timeout-improvements

Conversation

@jramsay
Copy link
Copy Markdown
Member

@jramsay jramsay commented Jan 24, 2024

Improve timeout messaging to help diagnose cancellation issues

Other Tasks:

  • If you updated the Go SDK did you update the PackageVersion in tunnels.go
  • [ X] If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version(Found using npm view @microsoft/dev-tunnels-contracts). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See example PR

Copy link
Copy Markdown

@osortega osortega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@setaskin setaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jramsay jramsay merged commit 01cfddf into main Jan 24, 2024
@jramsay jramsay deleted the dev/jasonra/timeout-improvements branch January 24, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants