Skip to content

Updating to the latest version of axios#385

Merged
jramsay merged 1 commit intomainfrom
dev/jasonra/cancel-improvements
Jan 25, 2024
Merged

Updating to the latest version of axios#385
jramsay merged 1 commit intomainfrom
dev/jasonra/cancel-improvements

Conversation

@jramsay
Copy link
Copy Markdown
Member

@jramsay jramsay commented Jan 25, 2024

Changes proposed:

  • updating to the latest version of axios
  • update to consistent error message prefix for 'ECONNABORTED' scenarios
  • return 'ECONNABORTED' error.code for both cases to allow for consumers to retry in this scenario

Other Tasks:

  • If you updated the Go SDK did you update the PackageVersion in tunnels.go
  • If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version(Found using npm view @microsoft/dev-tunnels-contracts). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See example PR

- update error message and always return error.code = 'ECONNABORTED' for both cases to allow for codespaces to retry in this scenario
Copy link
Copy Markdown
Contributor

@setaskin setaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jramsay jramsay merged commit 8bc5f88 into main Jan 25, 2024
@jramsay jramsay deleted the dev/jasonra/cancel-improvements branch January 25, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants