Skip to content

Increase socket connection retry delay and add socket onclose event#387

Merged
jramsay merged 2 commits intomainfrom
dev/jasonra/increase-socket-connection-retry-delay
Jan 29, 2024
Merged

Increase socket connection retry delay and add socket onclose event#387
jramsay merged 2 commits intomainfrom
dev/jasonra/increase-socket-connection-retry-delay

Conversation

@jramsay
Copy link
Copy Markdown
Member

@jramsay jramsay commented Jan 29, 2024

Changes proposed:

Other Tasks:

  • If you updated the Go SDK did you update the PackageVersion in tunnels.go
  • [X ] If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version(Found using npm view @microsoft/dev-tunnels-contracts). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See example PR

1,2,4,8,16 s
- Add reject with onclose event info when available
@jramsay jramsay merged commit 5de7e65 into main Jan 29, 2024
@jramsay jramsay deleted the dev/jasonra/increase-socket-connection-retry-delay branch January 29, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants