Skip to content

rs: fix error logs and compilation warning on non-windows#390

Merged
connor4312 merged 1 commit intomainfrom
connor4312/fix-logs-and-warning
Jan 29, 2024
Merged

rs: fix error logs and compilation warning on non-windows#390
connor4312 merged 1 commit intomainfrom
connor4312/fix-logs-and-warning

Conversation

@connor4312
Copy link
Copy Markdown
Member

@connor4312 connor4312 commented Jan 29, 2024

Fixes #388

Changes proposed:

  • Avoids noisy error logging if no access policies are configured
  • Fixes a compilation warning, and generate the user agent string in a slightly DRY-er way

Other Tasks:

  • If you updated the Go SDK did you update the PackageVersion in tunnels.go
  • If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version(Found using npm view @microsoft/dev-tunnels-contracts). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See example PR

@connor4312 connor4312 enabled auto-merge (squash) January 29, 2024 23:12
@connor4312 connor4312 merged commit d033e5d into main Jan 29, 2024
@connor4312 connor4312 deleted the connor4312/fix-logs-and-warning branch January 29, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rust SDK logs lots of noisy errors if no policy is in place in registry

2 participants