Skip to content

Add endpoint connection mode query param#392

Merged
jfullerton44 merged 12 commits intomainfrom
dev/jfullerton/endpoint2
Jan 30, 2024
Merged

Add endpoint connection mode query param#392
jfullerton44 merged 12 commits intomainfrom
dev/jfullerton/endpoint2

Conversation

@jfullerton44
Copy link
Copy Markdown
Collaborator

Fixes #

Changes proposed:

  • Adds endpoint connection mode query param to fix issue where endpoint is always returned as local network

Other Tasks:

  • If you updated the Go SDK did you update the PackageVersion in tunnels.go
  • If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version(Found using npm view @microsoft/dev-tunnels-contracts). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See example PR

@jfullerton44 jfullerton44 merged commit c1bf142 into main Jan 30, 2024
@jfullerton44 jfullerton44 deleted the dev/jfullerton/endpoint2 branch January 30, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants