Skip to content

Remove internal usage of ValidateTokenExpiration.#393

Merged
jramsay merged 2 commits intomainfrom
dev/jasonra/remove-token-validation
Jan 31, 2024
Merged

Remove internal usage of ValidateTokenExpiration.#393
jramsay merged 2 commits intomainfrom
dev/jasonra/remove-token-validation

Conversation

@jramsay
Copy link
Copy Markdown
Member

@jramsay jramsay commented Jan 31, 2024

Changes proposed:

  • Remove internal usage of ValidateTokenExpiration. It is based on user's system time and is causing reliability issues where "The access token is expired" is reported due to client system time issues.
  • Add a note to all external API validation calls that this uses client's system time for validation

Other Tasks:

  • If you updated the Go SDK did you update the PackageVersion in tunnels.go
  • If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version(Found using npm view @microsoft/dev-tunnels-contracts). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See example PR

@jramsay jramsay merged commit 56e1761 into main Jan 31, 2024
@jramsay jramsay deleted the dev/jasonra/remove-token-validation branch January 31, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants