Skip to content

rs: allow parsing proxies given as full URIs#394

Merged
connor4312 merged 1 commit intomainfrom
connor4312/proxy-by-http-addr
Feb 1, 2024
Merged

rs: allow parsing proxies given as full URIs#394
connor4312 merged 1 commit intomainfrom
connor4312/proxy-by-http-addr

Conversation

@connor4312
Copy link
Copy Markdown
Member

@connor4312 connor4312 commented Jan 31, 2024

Rather than only host:port

For microsoft/vscode#201417

Changes proposed:

  • HTTPS_PROXY may be given as a URI rather than just host:port. Doing so is rather extraneous since only the host and port are used, but handle parsing it anyway.

Other Tasks:

  • If you updated the Go SDK did you update the PackageVersion in tunnels.go
  • If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version(Found using npm view @microsoft/dev-tunnels-contracts). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See example PR

@connor4312 connor4312 enabled auto-merge (squash) January 31, 2024 16:33
@connor4312 connor4312 merged commit 4de1ff7 into main Feb 1, 2024
@connor4312 connor4312 deleted the connor4312/proxy-by-http-addr branch February 1, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants