Skip to content

Update displayed error message for enterprise policies#405

Merged
neelip merged 13 commits intomainfrom
dev/neelip/fix-error-msg-policies
Feb 27, 2024
Merged

Update displayed error message for enterprise policies#405
neelip merged 13 commits intomainfrom
dev/neelip/fix-error-msg-policies

Conversation

@neelip
Copy link
Copy Markdown
Contributor

@neelip neelip commented Feb 22, 2024

Fixes #54175005

Changes proposed:

  • Currently the response shows as such:
    image
  • Updated to only show the text in "detail" rathe than displaying the whole json object in the response.

Other Tasks:

  • If you updated the Go SDK did you update the PackageVersion in tunnels.go
  • If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version(Found using npm view @microsoft/dev-tunnels-contracts). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See example PR

Comment thread cs/src/Management/TunnelManagementClient.cs Outdated
Copy link
Copy Markdown
Contributor

@IlyaBiryukov IlyaBiryukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to be a breaking change for the client because the service still returns a string, not JSON in this case?

Comment thread cs/src/Management/TunnelManagementClient.cs Outdated
@neelip
Copy link
Copy Markdown
Contributor Author

neelip commented Feb 22, 2024

Is this going to be a breaking change for the client because the service still returns a string, not JSON in this case?

The Enterprise policies should be sending the json object with the latest release. All 3 policies only send JSON object.

IlyaBiryukov
IlyaBiryukov previously approved these changes Feb 23, 2024
@neelip neelip enabled auto-merge (squash) February 27, 2024 01:13
@neelip neelip merged commit 10c2848 into main Feb 27, 2024
@neelip neelip deleted the dev/neelip/fix-error-msg-policies branch February 27, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants