Skip to content

Pin es5-ext to 0.10.53#45

Merged
jessetrinity merged 1 commit intomainfrom
dev/jetrinit/pin-es5-ext
Apr 5, 2022
Merged

Pin es5-ext to 0.10.53#45
jessetrinity merged 1 commit intomainfrom
dev/jetrinit/pin-es5-ext

Conversation

@jessetrinity
Copy link
Copy Markdown
Contributor

Our package is being flagged by component governance for the dependency es5-ext which contains anti-war protest messages. See medikoo/es5-ext#116. There is no newer package which can be used at this time.

Since es5-ext is an indirect dependency, adding a pinned version as a direct dependency should cause the upstream packages to choose that version (0.10.53) which does not contain the flagged commit.

@jessetrinity jessetrinity merged commit 5920da4 into main Apr 5, 2022
@jessetrinity jessetrinity deleted the dev/jetrinit/pin-es5-ext branch April 5, 2022 21:29
@jessetrinity
Copy link
Copy Markdown
Contributor Author

Yarn will still pull in 0.10.59 with this fix. The workaround until we have a more permanent solution is to add a resolutions field

"resolutions": {
    "es5-ext": "0.10.53"
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants