Split non-prod GitHub App into separate per-environment apps and new Local environment config#619
Closed
jpablo2002 wants to merge 10 commits intomainfrom
Closed
Split non-prod GitHub App into separate per-environment apps and new Local environment config#619jpablo2002 wants to merge 10 commits intomainfrom
jpablo2002 wants to merge 10 commits intomainfrom
Conversation
…g locally, for each language
jpablo2002
changed the title
added 4 commits
April 22, 2026 10:19
…g locally, for each language
…thub.com/microsoft/dev-tunnels into dev/acostajuan/update-config-github-apps
klvnraju
reviewed
Apr 22, 2026
| /// GitHub app with localhost callback URLs. | ||
| /// </remarks> | ||
| public static TunnelServiceProperties Local { get; } = new TunnelServiceProperties( | ||
| $"https://{DevDnsName}/", |
Collaborator
There was a problem hiding this comment.
Should this be DevDnsName for local?
Contributor
Author
There was a problem hiding this comment.
It should be fine as is. This is how it used to be for local when it used the Development TunnelServiceProperties. The ServiceUri is a default fallback; in practice, local consumers always override it with an explicit localhost URL (e.g. we override it via DEVTUNNELS_SERVICE=local in the CLI)
Contributor
Author
There was a problem hiding this comment.
I've pushed new changes to add the LocalDnsName to be tunnels.local.api.visualstudio.com:9901
added 5 commits
April 22, 2026 11:45
…alstudio.com:9901
…thub.com/microsoft/dev-tunnels into dev/acostajuan/update-config-github-apps
Contributor
Author
|
Git diffs and generation of files broke and got messy, abandoning and making new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Splits the shared NonProdGitHubAppClientId into three separate GitHub OAuth apps with dedicated client IDs:
Changes proposed:
Adds a new Local environment to TunnelServiceProperties across all 5 SDK languages (C#, TypeScript, Go, Java, Rust),
with a "local" case in the Environment() method.
This enables the tunnel service and CLI to use different GitHub apps per environment, so each app can have properly
scoped callback URLs and independent secret rotation.