rust: implement relay client#626
Open
connor4312 wants to merge 5 commits intomicrosoft:mainfrom
Open
Conversation
- chrono->jiff as chrono is going into maintence mode chronotope/chrono#1423 (comment) - async-trait replaced when possible with Rust 1.75+ native async traits; kept for compat with russh - futures->futures_util, underlying library for just the things we need - urlencoding->percent-encoding as it's already a dep of the url module, so just one less dependency - general version updates Verified in the VS Code CLI that tunnel functionality still works as expected with these updates.
Rust had a relay host, but never actually implemented a relay client. - Imnplement relay_tunnel_client.rs (of course) - Updated incorrect type generation of some Rust models. These were just never hit in my code paths before, previously list_tunnels/get_tunnels could never return TunnelRelayTunnelEndpoint information. Now our Rust structure matches what Go does where TunnelRelayTunnelEndpoint is a field inside the TunnelEndpoint struct, so its fields are accessible. - GPT 5.5 did some very impressive analysis to find the bug that led to adding `CHANNEL_WRITE_CHUNK_SIZE`. This was just never something I hit consistently enough before to repro and fix.
This was referenced Apr 27, 2026
DavidObando
reviewed
Apr 28, 2026
Member
DavidObando
left a comment
DavidObando
left a comment
There was a problem hiding this comment.
Consulting on one security-sensitive item. Will approve if things check out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📣 Builds upon #624 -- only the last commit in this PR is new
Rust had a relay host, but never actually implemented a relay client.
CHANNEL_WRITE_CHUNK_SIZE. This was just never something I hit consistently enough before to repro and fix.