This repository was archived by the owner on Dec 8, 2025. It is now read-only.
gamepad client apis #573
Merged
gamepad client apis #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoskal
reviewed
Jul 21, 2023
Contributor
mmoskal
left a comment
mmoskal
left a comment
There was a problem hiding this comment.
love the combo or button - clean and simple!
| } | ||
|
|
||
| ds.Gamepad.prototype.axes = function axes() { | ||
| let r = (this as any).__axes as ds.ClientRegister<{ x: number; y: number }> |
Contributor
There was a problem hiding this comment.
I think you can extend the ds.Gamepad interface (I know it's a class, but I think you can do interface) and add this field
| } | ||
|
|
||
| emit(newValue: T) { | ||
| if (this.value !== newValue) { |
Contributor
There was a problem hiding this comment.
was there a problem with this?
Member
Author
There was a problem hiding this comment.
it's a bit misleading because in the case of axes ({x, y}), the equality check is not really useful.
Contributor
There was a problem hiding this comment.
sure, but this is generic - what if people use for say booleans?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #573