This repository was archived by the owner on Dec 8, 2025. It is now read-only.
support for LED driver + simulation #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoskal
reviewed
Aug 11, 2023
| * @param startColor | ||
| * @param endColor | ||
| */ | ||
| export function fillGradient( |
Contributor
There was a problem hiding this comment.
I think these fills and rainbows should be methods on the PixelBuffer, otherwise they are rather hard to discover
Member
Author
There was a problem hiding this comment.
I'm trying to avoid to turn pixelbuffer into a monster
| * Create a color buffer that allows you to manipulate a range of pixels | ||
| * @param numPixels number of pixels | ||
| */ | ||
| export function pixelBuffer(numPixels: number) { |
Contributor
There was a problem hiding this comment.
this probably should be PixelBuffer.alloc() to follow Buffer.alloc()
pelikhan
commented
Aug 17, 2023
| if (this._gamma) correctGamma(r, this._gamma) | ||
| b = r | ||
| } | ||
| // TODO: render b to hardware |
Contributor
There was a problem hiding this comment.
not anymore :) https://github.com/microsoft/devicescript/blob/main/packages/drivers/src/ledserver.ts#L159 - added it a couple days ago
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for driving programmable LEDs.
The jacdac-docs is already deployed and the
mainled.tsworks in the simulator.