Supress CredScanner #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { "DOCacheHost", "10.0.0.100:80,myhost2.com:8080" }, | ||
| { "IoTConnectionString", "HostName=instance-company-iothub-ver.host.tld;DeviceId=user-dev-name;SharedAccessKey=abcdefghijklmnopqrstuvwxyzABCDE123456789012=;GatewayHostName=10.0.0.200" } | ||
| // [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Not credentials (false positive)")] | ||
| { "IoTConnectionString", "HostName=instance-company-iothub-ver.host.tld;DeviceId=user-dev-name;SharedAccessKey=dummysha256hash;GatewayHostName=10.0.0.200" } |
Collaborator
There was a problem hiding this comment.
dummysha256hash [](start = 115, length = 15)
Is changing the string required even with the suppression? #Resolved
jimson-msft
changed the title
Collaborator
Need it above this line too? #Resolved Refers to: client-lite/test/mcc_manager.tests.cpp:104 in d6bf3fb. [](commit_id = d6bf3fb, deletion_comment = False) |
Collaborator
|
Update PR title to reflect the move to suppression. #Resolved |
Collaborator
|
By the way, for PRs with a single commit, I've noticed that github doesn't use the PR title when merging. We'll need to double check these.. In reply to: 809689341 [](ancestors = 809689341) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress CredScanner