Skip to content

Conversation

@shishirb-MSFT
Copy link
Collaborator

  • During an upgrade, postrm script deletes the 'do' group causing 'adu' membership to be removed.
  • postrm script is now updated to perform cleanup only on remove and purge actions. postinst script already handled the case of existing user/group entities.
  • Also move systemctl reset-failed to postinst as the more appropriate location. If retaining in prerm, we will have to take a call on whether to call it only on upgrade/abort-upgrade/etc.

@shishirb-MSFT shishirb-MSFT requested a review from a team as a code owner September 26, 2022 21:49
@jw-msft
Copy link

jw-msft commented Sep 27, 2022

unless I'm missing something, it seems like postrm.in.sh and prerm.in.sh need set -e so it will return failure ret code when individual commands fail so that it does not leave the install/upgrade in a partial state.

@shishirb-MSFT
Copy link
Collaborator Author

Agree about set -e but it is not in scope for this PR. Adding set -e requires more changes like deleting file/directory only if it exists.

@shishirb-MSFT shishirb-MSFT merged commit a4d5bd8 into develop Sep 28, 2022
@shishirb-MSFT shishirb-MSFT deleted the user/shishirb/working-branch branch September 28, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants