SDK: Add get_property support, remove callbacks and vectors from properties#153
Merged
JeffreySaathoff merged 5 commits intodevelopfrom Feb 8, 2023
Merged
SDK: Add get_property support, remove callbacks and vectors from properties#153JeffreySaathoff merged 5 commits intodevelopfrom
JeffreySaathoff merged 5 commits intodevelopfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" In reply to: 1414553893 In reply to: 1414553893 |
| ~download_property_value() = default; | ||
|
|
||
| static std::error_code make(const std::string& val, download_property_value& out); | ||
| static std::error_code make(const char* val, download_property_value& out) { return make(std::string(val), out); } |
Collaborator
Contributor
Author
There was a problem hiding this comment.
Haven't looked at the code generation, but it picks the wrong overload (probably bool), so we need these overloads.
| std::error_code as(std::vector<unsigned char>& val) const noexcept; | ||
| std::error_code as(status_callback_t& val) const noexcept; | ||
|
|
||
| #if defined(DO_INTERFACE_COM) |
Collaborator
There was a problem hiding this comment.
I'm convinced about this, so we can remove the ifdef. #Closed
| This is so any user of the SDK does not have to worry about supplying platform specific compile definitions to use the SDK | ||
| */ | ||
| // Values for download_property::security_flags | ||
| enum class download_security_flags : uint32_t |
Collaborator
Contributor
Author
There was a problem hiding this comment.
Discussed offline. Removing for now.
| explicit unique_variant(const VARIANT& other) noexcept; // takes ownership via shallow copy | ||
| unique_variant(const unique_variant& other); // true copy | ||
| unique_variant(unique_variant&& other) noexcept; | ||
| unique_variant& operator=(unique_variant&& other); |
Collaborator
| using native_type = boost::variant<std::string, uint32_t, uint64_t, bool, std::vector<unsigned char>>; | ||
| using native_type = boost::variant<std::string, uint32_t, uint64_t, bool>; | ||
| #endif | ||
| CDownloadPropertyValueInternal(); |
Collaborator
Collaborator
|
FYI - when completing the PR, github adds all commit messages into the squashed commit. Need to remove/re-format as needed before clicking the 'confirm merge' button. |
JeffreySaathoff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.