Merge branch develop into main [2023_02_03] #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shishirb-MSFT
commented
Feb 3, 2023
shishirb-MSFT
commented
- Pulls in a fix to workaround FindBoost issue on Ubuntu 20.04
* Bootstrap script. * Remove Dockerfile, use variable for deb10 in sdk docker build.
* Force cmake to use "/usr" instead of "/" on Linux, so that Boost::headers does not end up with the non-existent "/include" path. * Forcing /usr leads to the boost config files like BoostConfig.cmake to be loaded from /usr/lib instead of /lib (applicable to systems, like Ubuntu 20.04, where /lib is a symlink to /usr/lib). * The issue occurs only when PATH contains /bin before /usr/bin, although I do not understand how it is related to the lib paths. * Forcing cmake to run from /usr/bin/cmake instead of /bin/cmake was not sufficient to resolve the problem.
* A recent change to build agents removed the VCPKG_ROOT environment variable. * Switch to the VCPKG_INSTALLATION_ROOT variable instead.
* Regular builds no longer run on the main branch, rendering the status badges useless. * Switch to the develop branch instead.
Jerry-GeGarcia
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.