Skip to content

Add support for streamed output#156

Merged
JeffreySaathoff merged 3 commits intodevelopfrom
user/jeffreys/streamedOutput
Feb 9, 2023
Merged

Add support for streamed output#156
JeffreySaathoff merged 3 commits intodevelopfrom
user/jeffreys/streamedOutput

Conversation

@JeffreySaathoff
Copy link
Contributor

No description provided.

@JeffreySaathoff JeffreySaathoff requested a review from a team as a code owner February 9, 2023 20:12
uint64_t downloadedBytes = 0;
simpleDownload->set_output_stream([&downloadedBytes](const unsigned char*, size_t cb) -> std::error_code { downloadedBytes += cb; return DO_OK; });

simpleDownload->start_and_wait_until_completion();
Copy link
Collaborator

@shishirb-MSFT shishirb-MSFT Feb 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start_and_wait_until_completion

get_property after completion will fail on xplat. Use TestHelpers::WaitForState to wait for transferred and call finalize() at the end. #Resolved

Copy link
Collaborator

@shishirb-MSFT shishirb-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JeffreySaathoff JeffreySaathoff merged commit 8b3bb68 into develop Feb 9, 2023
@JeffreySaathoff JeffreySaathoff deleted the user/jeffreys/streamedOutput branch February 9, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants