Skip to content

Conversation

@JeffreySaathoff
Copy link
Contributor

No description provided.

@JeffreySaathoff JeffreySaathoff requested a review from a team as a code owner February 11, 2023 01:16
using output_stream_callback_t = std::function<std::error_code(const unsigned char* data, size_t size)>;

// TODO: create a new header for things that aren't 'status' related, such as output_stream_callback_t and ranges
struct range
Copy link
Collaborator

@shishirb-MSFT shishirb-MSFT Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

range

Call it download_range. #Closed


std::unique_ptr<DO_DOWNLOAD_RANGES_INFO> spRanges(new(pvBuffer) DO_DOWNLOAD_RANGES_INFO());
spRanges->RangeCount = static_cast<uint32_t>(count);
if (count > 0)
Copy link
Collaborator

@shishirb-MSFT shishirb-MSFT Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (count > 0)

I think we should fail the call at the upper layer itself if count == 0. #Closed

Copy link
Collaborator

@shishirb-MSFT shishirb-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JeffreySaathoff JeffreySaathoff merged commit 4561954 into develop Feb 13, 2023
@JeffreySaathoff JeffreySaathoff deleted the user/jeffreys/ranges branch February 13, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants