Add implementation for EnumDownloads #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk-cpp/include/do_download.h
Outdated
| return set_property(download_property::cost_policy, static_cast<uint32_t>(value)); | ||
| } | ||
|
|
||
| // Returns existing downloads that are associated with the caller |
Collaborator
| { | ||
|
|
||
| enum class errc : int32_t | ||
| namespace errc |
Collaborator
There was a problem hiding this comment.
Why change to namespace? I think one of the std::error_code constructors expects enum (maybe we aren't using that c'tor today). #Closed
Collaborator
There was a problem hiding this comment.
Ok I see the other changes in do_error_helpers.h and other files now.
Ignore my comment above.
Contributor
Author
There was a problem hiding this comment.
I like it better without the typecasts
sdk-cpp/include/do_errors.h
Outdated
| do_e_invalid_state = static_cast<int32_t>(0x80D02013), // DO_E_INVALID_STATE | ||
| }; | ||
|
|
||
| constexpr auto e_not_impl = static_cast<int32_t>(0x80004001); // E_NOTIMPL |
Collaborator
Collaborator
There was a problem hiding this comment.
(prefixes were not required inside the enum either)
| ComPtr<IDOManager> manager; | ||
| RETURN_IF_FAILED(CoCreateInstance(__uuidof(DeliveryOptimization), nullptr, CLSCTX_LOCAL_SERVER, IID_PPV_ARGS(&manager))); | ||
| ComPtr<IEnumUnknown> spEnum; | ||
| RETURN_IF_FAILED(manager->EnumDownloads(pCategory, &spEnum)); |
Collaborator
| download2->get_property(msdo::download_property::id, downloadId2); | ||
| ASSERT_EQ(downloadId1, downloadId2); | ||
|
|
||
| download2->start_and_wait_until_completion(); |
Collaborator
added 2 commits
February 15, 2023 09:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.